On Thu, Apr 11, 2019 at 11:13:28AM +0300, Dan Carpenter wrote: > On Wed, Apr 10, 2019 at 02:49:09PM -0500, Madhumthia Prabakaran wrote: > > On Wed, Apr 10, 2019 at 09:49:54AM +0300, Dan Carpenter wrote: > > > On Tue, Apr 09, 2019 at 11:16:17AM -0500, Madhumitha Prabakaran wrote: > > > > diff --git a/drivers/staging/rtl8723bs/include/drv_types.h b/drivers/staging/rtl8723bs/include/drv_types.h > > > > index bafb2c30e7fb..b0623c936940 100644 > > > > --- a/drivers/staging/rtl8723bs/include/drv_types.h > > > > +++ b/drivers/staging/rtl8723bs/include/drv_types.h > > > > @@ -220,7 +220,7 @@ struct registry_priv > > > > #define BSSID_SZ(field) sizeof(((struct wlan_bssid_ex *) 0)->field) > > > > > > > > #include <drv_types_sdio.h> > > > > -#define INTF_DATA SDIO_DATA > > > > +#define INTF_DATA struct sdio_data > > > > > > > > > > Just get rid of INTF_DATA data as well. It's only used once a bit lower > > > in the file. (Get rid of the ifdef around it). > > > > But, reference of INTF_DATA is also included in file > > ./drivers/staging/rtl8723bs/include/drv_types.h:487: > > return &dvobj->intf_data.func->dev; > > > > Actually, I maybe misunderstood your email. I'm not sure what you mean > about "&dvobj->intf_data.func->dev;". I just meant to replace > INTF_DATA with "struct sdio_data". Sorry, I wasn't able to align my thoughts over ifdef. Thus, the confusion in fixing it. However, I edited it now. Thanks, Madhumitha > > regards, > dan carpenter > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
