On Thu, Apr 04, 2019 at 10:32:57AM +0100, Colin King wrote: > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > index 944c8894f9ff..c4a4f118f547 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c > @@ -2659,8 +2659,7 @@ static int ieee80211_wpa_set_wpa_ie(struct ieee80211_device *ieee, > { > u8 *buf; > > - if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || > - (param->u.wpa_ie.len && param->u.wpa_ie.data == NULL)) > + if (param->u.wpa_ie.len > MAX_WPA_IE_LEN || param->u.wpa_ie.len) > return -EINVAL; Nope... :P Don't do that... regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel