On Wed, Apr 03, 2019 at 06:51:49AM +1100, NeilBrown wrote: > People keep telling me that drivers/mmc/host/mtk-sd.c should be able to > handle the same hardware as this driver, with a little bit of work. > Unfortunately they haven't told me what the little bit of work involves. > > Have you explored that possibility at all? I might try to have a look > if I can make time. I have started to look into it, when I was working on that driver. First sorry for me doing nothing in the last few month. Generally the two drivers seem to be very similar, the main difference is the code for tuning. In the staging driver. this is a total mess. It tries to account for tuning itself, so it also tries to account which command was executed (succesfully) before a tuning is necessary and reexecutes it, when it was the APP_CMD. But there are still some differences in the tuning code, that are not due to handling it in the driver. If have mainly understand how to remove the 'in driver handling' of the tuning and thing I could prepare a patch for that. But the differences in the tuning code itself, I do not understand completely. There are two other larger differences that I found during my work. One is that drivers/mmc/host/mtk-sd.c has much more features, like voltage and clock handling and some support for high speed modes. I don't know if these features are required/useful for this device. The other thing is the card detect handling. This driver is doing the card detect / read only detection on its own, where the in tree one just uses some default gpio functions there and I don't know weather this must be changed or weather there is a gpio driver for the mt7621. That is all I currently remember. Hope it helps. Christian _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
