Re: [PATCH v3 07/14] staging: most: core: use device description as name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 02, 2019 at 08:10:25AM +0000, Christian.Gromm@xxxxxxxxxxxxx wrote:
> On Di, 2019-04-02 at 09:24 +0200, Greg KH wrote:
> > External E-Mail
> > 
> > 
> > On Mon, Apr 01, 2019 at 02:05:32PM +0200, Christian Gromm wrote:
> > > 
> > > This patch uses the device description to clearly identity a device
> > > attached to the bus. It is needed as the currently useed mdevX
> > > notation is not sufficiant in case more than one network
> > > interface controller is being used at the same time.
> > > 
> > > Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx>
> > > ---
> > > v2:
> > > v3:
> > > 
> > >  drivers/staging/most/core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/most/core.c
> > > b/drivers/staging/most/core.c
> > > index a5df53e..e0a6806 100644
> > > --- a/drivers/staging/most/core.c
> > > +++ b/drivers/staging/most/core.c
> > > @@ -1467,7 +1467,7 @@ int most_register_interface(struct
> > > most_interface *iface)
> > >  
> > >  	INIT_LIST_HEAD(&iface->p->channel_list);
> > >  	iface->p->dev_id = id;
> > > -	snprintf(iface->p->name, STRING_SIZE, "mdev%d", id);
> > > +	strcpy(iface->p->name, iface->description);
> > >  	iface->dev.init_name = iface->p->name;
> > >  	iface->dev.bus = &mc.bus;
> > >  	iface->dev.parent = &mc.dev;
> > Is this a stand-alone bugfix that can be taken now and should also be
> > added to the stable kernel trees?
> > 
> 
> Stable trees? The driver is not present there.... yet.

This driver has been in the kernel for many years, and this specific
file has been there since 4.16.  We have long term stable releases for
4.19 going at the moment.

If you don't care about the stable releases, that's fine, just asking :)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux