Re: [PATCH v3 05/14] staging: most: enable configfs support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Di, 2019-04-02 at 09:20 +0200, Greg KH wrote:
> External E-Mail
> 
> 
> On Mon, Apr 01, 2019 at 02:05:30PM +0200, Christian Gromm wrote:
> > 
> > This patch enables the configfs functionality of the driver by
> > registering the configfs subsystems and compiling the configfs
> > part of the sources.
> > 
> > Signed-off-by: Christian Gromm <christian.gromm@xxxxxxxxxxxxx>
> > ---
> > v2:
> > 	- remove call to configfs_exit function
> > v3:
> > 
> >  drivers/staging/most/Makefile      |  1 +
> >  drivers/staging/most/cdev/cdev.c   |  6 ++++++
> >  drivers/staging/most/core.c        |  2 +-
> >  drivers/staging/most/sound/sound.c | 11 ++++++++++-
> >  4 files changed, 18 insertions(+), 2 deletions(-)
> You add the file in patch 1, but do not add it to the build until
> patch
> 5?  Does that really work?
> 
Yes it does, because user space can still use sysfs to configure
the driver until patch 9/14 is being applied (which disables this
function). I've done things this way to provide you with a
clearly laid out patch queue.

> And what about Kconfig dependancies, don't you need to add a
> dependancy
> on configfs to the most core now?
> 

This dependency should be added, right. 

> thanks,
> 
> greg k-h
> _______________________________________________
> devel mailing list
> devel@xxxxxxxxxxxxxxxxxxxxxx
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
> vel
> 
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux