On Sun, Mar 31, 2019 at 06:53:36PM -0400, Will Cunningham wrote: > Removed unnecessary parentheses.` Odd trailing character :( > > Signed-off-by: Will Cunningham <wjcunningham7@xxxxxxxxx> > --- > drivers/staging/comedi/drivers/pcl818.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c > index 0af5315d4357..da5d53a288f7 100644 > --- a/drivers/staging/comedi/drivers/pcl818.c > +++ b/drivers/staging/comedi/drivers/pcl818.c > @@ -1012,7 +1012,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it) > pcl818_alloc_dma(dev, it->options[2]); > > /* use 1MHz or 10MHz oscilator */ > - if ((it->options[3] == 0) || (it->options[3] == 10)) > + if (it->options[3] == 0 || it->options[3] == 10) No, please leave as-is. () are there for humans to read, and having to always remember the order of operations is not something you ever want to do. I _REALLY_ hate this option of checkpatch :( greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
