Re: [PATCH v2 04/14] staging: most: sound: introduce new sound adapter management

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks, I feel like I understand better now.

Sorry, I don't want to be a jerk and I'm not going to complain again
about this patchset if you resend it with the other stuff I mention
fixed.

But to me it feels like the API could be improved slightly if you
first created the adapter with a name and then linked to it.  Creating
the adapter as a side effect of linking the first audio component feels
like it seems helpful but it's going to be awkward.

I'm also concerned about the locking around the adpt_list.  Is this
something ordinary users can trigger?  Is it crash if I set my fuzz
tester to start randomly connecting and disconnecting like crazy?

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux