On Fri, Mar 22, 2019 at 03:02:54PM +0100, Stefan Roese wrote: > On 21.03.19 15:25, Mark Brown wrote: > > > + list_for_each_entry(t, &m->transfers, transfer_list) > > > + if (t->speed_hz < speed) > > > + speed = t->speed_hz; > > This should be in the core if it's needed, it's going to be the same for > > all drivers. > I'm not sure here, other drivers might set the speed individually for > each "spi_transfer" entry. In this driver its set only once: before > beginning to transfer all entries. So should I really move this into > the core and set all speed_hz values to the minimum one of the list? Oh, I see what it's doing... the driver should really be setting the speed per transfer, though in practice I'm not convinced that anything ever varies within a single message.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
