On Mon, Mar 04, 2019 at 12:55:32AM +0800, Yifeng Li wrote: > Rename the function setDisplayControl() to set_display_control(). > This fixes the following checkpatch.pl warning: > > CHECK: Avoid CamelCase: <setDisplayControl> > > Suggested-by: Jin Chen <nobijinc@xxxxxxxxx> > Signed-off-by: Jin Chen <nobijinc@xxxxxxxxx> > [tomli@xxxxxxxx: resent as trivial patch, reworded the commit message] > Signed-off-by: Yifeng Li <tomli@xxxxxxxx> > --- Apparently Greg already applied this earlier... I don't know why the original patch didn't reach me. I'm on the devel@xxxxxxxxxxxxxxxxxxxx list. Did Jin Chen write this? If so why does it have a Suggested-by tag for him? If not then you should have preserved the authorship credit by using the From: header in the first line on the commit message... Anyway, it doesn't matter but hopefully this helps for next time. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel