Re: [PATCH] Staging: rtl8712: Fix comment position, it goes after statment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Mar 10, 2019 at 11:58:56PM -0300, Mauro Furer wrote:
>     This patch fixes checkpatch.pl warning in file rtl871x_io.h
>     WARNING : Statements should start on a tabstop

Fix the indenting in your commit message.

> 
> Signed-off-by: Mauro Furer <maurofurer@xxxxxxxxx>
> ---
>  drivers/staging/rtl8712/rtl871x_io.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl871x_io.h b/drivers/staging/rtl8712/rtl871x_io.h
> index 28941423b7ed..30a04e96f11e 100644
> --- a/drivers/staging/rtl8712/rtl871x_io.h
> +++ b/drivers/staging/rtl8712/rtl871x_io.h
> @@ -101,7 +101,7 @@ struct	_io_ops {
>  struct io_req {
>  	struct list_head list;
>  	u32	addr;
> -	/*volatile*/ u32	val;
> +	u32	val; /*volatile*/

Just delete the comment.  It's bogus dead code.

>  	u32	command;
>  	u32	status;
>  	u8	*pbuf;

regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux