Re: [PATCH] staging: fbtft: fixed format-string errors.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jeremy,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v5.0 next-20190306]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jeremy-Sowden/staging-fbtft-fixed-format-string-errors/20190308-122632
config: x86_64-randconfig-x017-201909 (attached as .config)
compiler: gcc-8 (Debian 8.3.0-2) 8.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/fbtft/fb_agm1264k-fl.c:15:
   drivers/staging/fbtft/fb_agm1264k-fl.c: In function 'write':
>> drivers/staging/fbtft/fb_agm1264k-fl.c:409:6: warning: format '%d' expects argument of type 'int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
         "%s(len=%d): ", __func__, len);
         ^~~~~~~~~~~~~~            ~~~
   drivers/staging/fbtft/fb_agm1264k-fl.c:408:2: note: in expansion of macro 'fbtft_par_dbg_hex'
     fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
     ^~~~~~~~~~~~~~~~~
--
   In file included from drivers/staging/fbtft/fb_ra8875.c:13:
   drivers/staging/fbtft/fb_ra8875.c: In function 'write_spi':
>> drivers/staging/fbtft/fb_ra8875.c:27:6: warning: format '%d' expects argument of type 'int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
         "%s(len=%d): ", __func__, len);
         ^~~~~~~~~~~~~~            ~~~
   drivers/staging/fbtft/fbtft.h:409:32: note: in definition of macro 'fbtft_par_dbg_hex'
             (num) * sizeof(type), format, ##arg); \
                                   ^~~~~~
--
   In file included from drivers/staging/fbtft/fbtft_device.c:15:
   drivers/staging/fbtft/fbtft_device.c: In function 'write_gpio16_wr_slow':
>> drivers/staging/fbtft/fbtft_device.c:968:6: warning: format '%d' expects argument of type 'int', but argument 7 has type 'size_t' {aka 'long unsigned int'} [-Wformat=]
         "%s(len=%d): ", __func__, len);
         ^~~~~~~~~~~~~~            ~~~
   drivers/staging/fbtft/fbtft.h:409:32: note: in definition of macro 'fbtft_par_dbg_hex'
             (num) * sizeof(type), format, ##arg); \
                                   ^~~~~~

vim +409 drivers/staging/fbtft/fb_agm1264k-fl.c

b2ebd4be Thomas Petazzoni 2014-12-31  405  
b2ebd4be Thomas Petazzoni 2014-12-31  406  static int write(struct fbtft_par *par, void *buf, size_t len)
b2ebd4be Thomas Petazzoni 2014-12-31  407  {
b2ebd4be Thomas Petazzoni 2014-12-31  408  	fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
b2ebd4be Thomas Petazzoni 2014-12-31 @409  			  "%s(len=%d): ", __func__, len);
b2ebd4be Thomas Petazzoni 2014-12-31  410  
c440eee1 Nishad Kamdar    2019-01-16  411  	gpiod_set_value(par->RW, 0); /* set write mode */
b2ebd4be Thomas Petazzoni 2014-12-31  412  
b2ebd4be Thomas Petazzoni 2014-12-31  413  	while (len--) {
b2ebd4be Thomas Petazzoni 2014-12-31  414  		u8 i, data;
b2ebd4be Thomas Petazzoni 2014-12-31  415  
b2ebd4be Thomas Petazzoni 2014-12-31  416  		data = *(u8 *)buf++;
b2ebd4be Thomas Petazzoni 2014-12-31  417  
b2ebd4be Thomas Petazzoni 2014-12-31  418  		/* set data bus */
b2ebd4be Thomas Petazzoni 2014-12-31  419  		for (i = 0; i < 8; ++i)
c440eee1 Nishad Kamdar    2019-01-16  420  			gpiod_set_value(par->gpio.db[i], data & (1 << i));
b2ebd4be Thomas Petazzoni 2014-12-31  421  		/* set E */
c440eee1 Nishad Kamdar    2019-01-16  422  		gpiod_set_value(par->EPIN, 1);
b2ebd4be Thomas Petazzoni 2014-12-31  423  		udelay(5);
b2ebd4be Thomas Petazzoni 2014-12-31  424  		/* unset E - write */
c440eee1 Nishad Kamdar    2019-01-16  425  		gpiod_set_value(par->EPIN, 0);
b2ebd4be Thomas Petazzoni 2014-12-31  426  		udelay(1);
b2ebd4be Thomas Petazzoni 2014-12-31  427  	}
b2ebd4be Thomas Petazzoni 2014-12-31  428  
b2ebd4be Thomas Petazzoni 2014-12-31  429  	return 0;
b2ebd4be Thomas Petazzoni 2014-12-31  430  }
b2ebd4be Thomas Petazzoni 2014-12-31  431  

:::::: The code at line 409 was first introduced by commit
:::::: b2ebd4be6fa1d2329b63531b044f9e25474981cb staging: fbtft: add fb_agm1264k-fl driver

:::::: TO: Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxxxxxxxxx>
:::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux