On Fri, Mar 01, 2019 at 04:27:25PM +0200, Oryan Perlmutter wrote: > drivers/staging/devices: Coding style fixes found at file vme_user.c. Your subject line, and this changelog text, need a lot of work. Please look at the other patches that have been accepted for this driver as examples of how to do this properly. > > Signed-off-by: Oryan Perlmutter <oryan.perl1997@xxxxxxxxx> > --- > drivers/staging/vme/devices/vme_user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vme/devices/vme_user.c b/drivers/staging/vme/devices/vme_user.c > index 6a33aaa1a49f..4c7db4f5f15e 100644 > --- a/drivers/staging/vme/devices/vme_user.c > +++ b/drivers/staging/vme/devices/vme_user.c > @@ -506,7 +506,7 @@ static int vme_user_match(struct vme_dev *vdev) > int cur_slot = vme_slot_num(vdev); > > for (i = 0; i < bus_num; i++) > - if ((cur_bus == bus[i]) && (cur_slot == vdev->num)) > + if (cur_bus == bus[i] && cur_slot == vdev->num) Personally, I like the original code here, it's more explicit as to what is going on. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
