> Subject: [PATCH net] staging: fsl-dpaa2: ethsw: Add missing netdevice check > > port_switchdev_event() does not check that the target network device is > actually backed by the ethsw driver, this could be problematic in a stacked > environment case. > Just FYI, I sent a patch set containing a similar patch verifying if the netdev is backed by the ethsw: https://lkml.org/lkml/2019/2/6/216 I sent the entire patch set against the staging tree. Ioana C > Fixes: 44baaa43d7cc ("staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet > Switch driver") > Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx> > --- > drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl- > dpaa2/ethsw/ethsw.c > index daabaceeea52..2edd82f5229a 100644 > --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c > +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c > @@ -1047,6 +1047,9 @@ static int port_switchdev_event(struct notifier_block > *unused, > struct ethsw_switchdev_event_work *switchdev_work; > struct switchdev_notifier_fdb_info *fdb_info = ptr; > > + if (!ethsw_port_dev_check(dev)) > + return NOTIFY_DONE; > + > switchdev_work = kzalloc(sizeof(*switchdev_work), GFP_ATOMIC); > if (!switchdev_work) > return NOTIFY_BAD; > -- > 2.17.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
