Re: [PATCH 1/2] media: ipu3: shut up warnings produced with W=1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mauro,

On Tue, Feb 19, 2019 at 09:00:29AM -0500, Mauro Carvalho Chehab wrote:
> There are lots of warnings produced by this driver. It is not
> as much as atomisp, but it is still a lot.
> 
> So, use the same solution to hide most of them.
> Those need to be fixed before promoting it out of staging,
> so add it at the TODO list.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>
> ---
>  drivers/staging/media/ipu3/Makefile | 6 ++++++
>  drivers/staging/media/ipu3/TODO     | 2 ++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/drivers/staging/media/ipu3/Makefile b/drivers/staging/media/ipu3/Makefile
> index fb146d178bd4..fa7fa3372bcb 100644
> --- a/drivers/staging/media/ipu3/Makefile
> +++ b/drivers/staging/media/ipu3/Makefile
> @@ -9,3 +9,9 @@ ipu3-imgu-objs += \
>  		ipu3-css.o ipu3-v4l2.o ipu3.o
>  
>  obj-$(CONFIG_VIDEO_IPU3_IMGU) += ipu3-imgu.o
> +
> +# HACK! While this driver is in bad shape, don't enable several warnings
> +#       that would be otherwise enabled with W=1
> +ccflags-y += $(call cc-disable-warning, packed-not-aligned)
> +ccflags-y += $(call cc-disable-warning, type-limits)
> +ccflags-y += $(call cc-disable-warning, unused-const-variable)

I'm preparing patches to address these. Could you wait a little bit more,
please?

Thanks.

-- 
Kind regards,

Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux