On Fri, Feb 15, 2019 at 11:01:59AM -0800, John Stultz wrote: > On Fri, Feb 15, 2019 at 2:51 AM Brian Starkey <Brian.Starkey@xxxxxxx> wrote: > > > > Hi John, > > > > On Thu, Feb 14, 2019 at 09:38:29AM -0800, John Stultz wrote: > > > > > [snip] > > > > > Some thoughts, as this ABI break has the potential to be pretty painful. > > > > > > 1) Unfortunately, this ABI is exposed *through* libion via > > > ion_alloc/ion_alloc_fd out to gralloc implementations. Which means it > > > will have a wider impact to vendor userland code. > > > > I figured libion could fairly easily loop through all the set bits in > > heap_mask and call the ioctl for each until it succeeds. That > > preserves the old behaviour from the libion clients' perspective. > > Potentially, though that implicitly still caps the heaps to 32. So > I'm not sure what the net benefit would be. > It's purely a transitionary compatibility measure. Users of the old API inherit the old limitation - they shouldn't care about that. Alongside it, we'd want to add new function(s) exposing whatever the new API is. Cheers, -Brian _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
