Hi Neil,
On Wed, Feb 13, 2019 at 1:24 AM NeilBrown <neil@xxxxxxxxxx> wrote:
>
> On Tue, Feb 12 2019, Sergio Paracuellos wrote:
>
> > This patch series make some minor cleanups of this driver in order
> > to prepare it to be promoted from staging. Changes are:
> > * use general pcie reset line in device tree and use reset_control
> > to handle it,
> > * some minor space-tabs issue.
> > * Some minor removes of not needed stuff.
> >
> > After this changes, only properly handling the clocks with a new
> > driver is remaining.
> >
> > All changes are only compile-tested.
> >
> > Hope this helps.
> >
> > Best regards,
> > Sergio Paracuellos
> >
> > Sergio Paracuellos (5):
> > staging: mt7621-pci: add reset control for general pcie reset
> > staging: mt7621-dts: add general pcie reset line to pcie bindings
> > staging: mt7621-pci: remove not used definitions
> > staging: mt7621-pci: replace spaces with tabs in comment
> > staging: mt7621-pci: remove two register writes
> >
> > drivers/staging/mt7621-dts/mt7621.dtsi | 4 +--
> > drivers/staging/mt7621-pci/pci-mt7621.c | 39 ++++++++++++-------------
> > 2 files changed, 21 insertions(+), 22 deletions(-)
>
> Thanks for these. They may sense to me.
>
> I tried testing and am not having much luck - but that isn't because of
> these patches.
> Building
> Commit 209312369e6d ("staging: erofs: remove redundant unlikely annotation in unzip_vle.c")
>
> (current staging-next branch) with
>
> CONFIG_PCI_MT7621=y
> CONFIG_PCI_MT7621_PHY=y
>
> results in
>
> [ 0.480000] mt7621-pci 1e140000.pcie: Parsing DT failed
> [ 0.490000] mt7621-pci-phy 1a149000.pcie-phy: can't request region for resource [mem 0x1a149000-0x1a1496ff]
> [ 0.510000] mt7621-pci-phy 1a149000.pcie-phy: failed to remap phy regs
> [ 0.520000] mt7621-pci-phy: probe of 1a149000.pcie-phy failed with error -16
> [ 0.530000] mt7621-pci-phy 1a14a000.pcie-phy: can't request region for resource [mem 0x1a14a000-0x1a14a6ff]
> [ 0.550000] mt7621-pci-phy 1a14a000.pcie-phy: failed to remap phy regs
> [ 0.570000] mt7621-pci-phy: probe of 1a14a000.pcie-phy failed with error -16
I don't really understand why phy driver cannot remap properly these
regions. This is being done apparently properly in
mt7621-pci-phy probe function and addresses for resources in this log
are both ok.
> ...
>
> [ 10.260000] rt2880-pinmux pinctrl: pcie is already enabled
> [ 10.270000] mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
> [ 10.280000] mt7621-pci 1e140000.pcie: Parsing DT failed
> [ 10.290000] rt2880-pinmux pinctrl: pcie is already enabled
> [ 10.300000] mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
> [ 10.320000] mt7621-pci 1e140000.pcie: Parsing DT failed
> .....
> [ 10.630000] rt2880-pinmux pinctrl: pcie is already enabled
> [ 10.640000] mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
> ...
> [ 10.650000] mt7621-pci 1e140000.pcie: Parsing DT failed
> ...
> [ 10.700000] rt2880-pinmux pinctrl: pcie is already enabled
> [ 10.710000] mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
> [ 10.720000] mt7621-pci 1e140000.pcie: Parsing DT failed
> ...
> [ 11.320000] rt2880-pinmux pinctrl: pcie is already enabled
> [ 11.330000] mt7621-pci 1e140000.pcie: Error applying setting, reverse things back
> [ 11.350000] mt7621-pci 1e140000.pcie: Parsing DT failed
pinctrl errors seems to be related with pcie device tree:
pinctrl-names = "default";
pinctrl-0 = <&pcie_pins>;
where
pcie_pins: pcie0 {
pcie0 {
groups = "pcie";
function = "pcie rst";
};
};
Maybe adding some extra traces to mt7621_pcie_parse_dt in some error
paths is helpful.
>
>
> So something is messed up somewhere.
> I might be able to have a deeper look on the weekend.
That would be really helpful, thank you.
>
> NeilBrown
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
