Hi, Please, drop this. I've just sent v2 with the right Fixes tag: https://lore.kernel.org/patchwork/patch/1041301/ Thanks -- Gustavo On 2/12/19 12:08 PM, Gustavo A. R. Silva wrote: > Add missing break statement in order to prevent the code from falling > through to the default case and return -EINVAL every time. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: 58dd7c0a2a6e ("Staging: comedi: add ni_660x driver") > Cc: stable@xxxxxxxxxxxxxxx > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > --- > drivers/staging/comedi/drivers/ni_660x.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/staging/comedi/drivers/ni_660x.c > index e70a461e723f..405573e927cf 100644 > --- a/drivers/staging/comedi/drivers/ni_660x.c > +++ b/drivers/staging/comedi/drivers/ni_660x.c > @@ -656,6 +656,7 @@ static int ni_660x_set_pfi_routing(struct comedi_device *dev, > case NI_660X_PFI_OUTPUT_DIO: > if (chan > 31) > return -EINVAL; > + break; > default: > return -EINVAL; > } > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
