Some of the things included in driver's TODO file have been properly achieved. Update file accordly. Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx> --- Hi Neil, I've been looking through the code of this driver and pci-phy driver while thinking in what is missing already to get this mainlined out of staging. I don't really know what cleanups are missing here. The only thinkg is not clear yet is the thing with the clocks defined in device-tree. Should be just remove them and give this stuff a try to get feedback or what is missing? Can you please point me out in the right direction? Thanks in advance for your time. Best regards, Sergio Paracuellos drivers/staging/mt7621-pci/TODO | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/staging/mt7621-pci/TODO b/drivers/staging/mt7621-pci/TODO index cf30f629b9fd..ccfd266db4ca 100644 --- a/drivers/staging/mt7621-pci/TODO +++ b/drivers/staging/mt7621-pci/TODO @@ -1,12 +1,4 @@ - general code review and cleanup -- can this be converted to not require PCI_DRIVERS_LEGACY ?? - The irq returned by pcibios_map_irq is a "hwirq" (hardware irq number) - and pci_assign_irq() assigns this directly to dev->irq, which - expects a "virq" (virtual irq number). These numbers are different - on MIPS. There is a gross hack to make it work on one - specific platform, so it can be tested. -- Should this be merged with arch/mips/pci/pci-mt7620.c ?? -- ensure device-tree requirements are documented Cc: NeilBrown <neil@xxxxxxxxxx> -- 2.19.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel