On Thu, Feb 07, 2019 at 07:22:25AM +0000, Ajay.Kathat@xxxxxxxxxxxxx wrote:
> From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
>
> Set correct interface count value in '->vif_num'.
> 'vif_num' was incorrectly set one less than total number of interfaces
> because 'i' is used to set its value, which starts from 0.
>
> Fixes: 735bb39ca3be ("staging: wilc1000: simplify vif[i]->ndev accesses")
> Cc: <stable@xxxxxxxxxxxxxxx> # v4.10
> Signed-off-by: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx>
> ---
> drivers/staging/wilc1000/linux_wlan.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
> index 648b658..8fa5f90 100644
> --- a/drivers/staging/wilc1000/linux_wlan.c
> +++ b/drivers/staging/wilc1000/linux_wlan.c
> @@ -1021,7 +1021,7 @@ int wilc_netdev_init(struct wilc **wilc, struct device *dev, int io_type,
The line before the diff looks like this:
vif->idx = wl->vif_num;
can we can change that to:
vif->idx = i;
It's the same thing, but more clear.
> vif->wilc = *wilc;
> vif->ndev = ndev;
> wl->vif[i] = vif;
> - wl->vif_num = i;
> + wl->vif_num = i + 1;
> ndev->netdev_ops = &wilc_netdev_ops;
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
