Re: [PATCH 3/3] staging: rtl8192e: rename members of struct rtllib_device - style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 05, 2019 at 07:22:11PM +0100, Greg KH wrote:
> On Tue, Feb 05, 2019 at 09:42:39AM -0800, Himadri Pandya wrote:
> > Rename following members of struct rtllib_device to fix checkpatch
> > warning: Avoid CamelCase
> > 
> > 	pDot11dInfo -> dot11d_info
> >         bGlobalDomain -> global_domain
> >         IbssStartChnl -> ibss_start_chnl
> 
> Why the use of tabs on the first line and not on the others?
> 
> Anyway, same comment here, "ibss_start_channel"?

Oops, no, it should be "bss_start_channel", no need for the initial "i",
that was left over from the horrid notation style.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux