Hi all, Based on discussion with Ido and feedback from Jakub there are clearly two classes of users that implement SWITCHDEV_ATTR_ID_PORT_PARENT_ID: - PF/VF drivers which typically only implement return the port's parent ID, yet have to implement switchdev_port_attr_get() just for that - Ethernet switch drivers: mlxsw, ocelot, DSA, etc. which implement more attributes which we want to be able to eventually veto in the context of the caller, thus making them candidates for using a blocking notifier chain Changes from RFC: - introduce a ndo_get_port_parent_id() and convert all relevant drivers to use it - get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID A subsequent set of patches will convert switchdev_port_attr_set() to use a blocking notifier call, and still get rid of switchdev_port_attr_get() altogether. Florian Fainelli (12): net: Introduce ndo_get_port_parent_id() bnxt: Implement ndo_get_port_parent_id() liquidio: Implement ndo_get_port_parent_id() net/mlx5e: Implement ndo_get_port_parent_id() mlxsw: Implement ndo_get_port_parent_id() mscc: ocelot: Implement ndo_get_port_parent_id() nfp: Implement ndo_get_port_parent_id() rocker: Implement ndo_get_port_parent_id() netdevsim: Implement ndo_get_port_parent_id() staging: fsl-dpaa2: ethsw: Implement ndo_get_port_parent_id() net: dsa: Implement ndo_get_port_parent_id() net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 +++++---------- drivers/net/ethernet/broadcom/bnxt/bnxt.h | 4 +-- drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 1 + drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 12 +++---- .../net/ethernet/cavium/liquidio/lio_main.c | 22 +++--------- .../net/ethernet/cavium/liquidio/lio_vf_rep.c | 25 ++++--------- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 31 ++++++---------- .../net/ethernet/mellanox/mlxsw/spectrum.c | 13 +++++++ .../mellanox/mlxsw/spectrum_switchdev.c | 5 --- .../net/ethernet/mellanox/mlxsw/switchx2.c | 36 +++++++------------ drivers/net/ethernet/mscc/ocelot.c | 33 +++++++---------- .../ethernet/netronome/nfp/nfp_net_common.c | 4 +-- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 4 +-- drivers/net/ethernet/netronome/nfp/nfp_port.c | 23 ++++-------- drivers/net/ethernet/netronome/nfp/nfp_port.h | 4 ++- drivers/net/ethernet/rocker/rocker_main.c | 17 ++++++--- drivers/net/netdevsim/netdev.c | 22 ++++-------- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 17 ++++++--- include/linux/netdevice.h | 6 ++++ include/net/switchdev.h | 2 -- net/bridge/br_switchdev.c | 11 +++--- net/core/net-sysfs.c | 14 +++----- net/core/rtnetlink.c | 16 ++++----- net/dsa/slave.c | 18 ++++++---- net/ipv4/ipmr.c | 14 ++++---- net/switchdev/switchdev.c | 20 +++++------ 26 files changed, 169 insertions(+), 233 deletions(-) -- 2.17.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel