Re: [PATCH 1/9 v3] staging: spi: mt7621: Switch to SPDX identifier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 01 2019, Mark Brown wrote:

> On Fri, Feb 01, 2019 at 11:17:07AM +0100, Stefan Roese wrote:
>
>> @@ -1,3 +1,4 @@
>> +// SPDX-License-Identifier: GPL-2.0
>>  /*
>>   * spi-mt7621.c -- MediaTek MT7621 SPI controller driver
>>   *
>
> Please convert the entire comment into a C++ comment so it looks more
> intentional.

Hi Mark,
 I don't understand what you mean by this, or possibly I do understand
 and strongly disagree.

 It is extremely common in the kernel for a file to start
   // SPDX-License-Identifier.....

 and to have that immediately followed by a comment lile:

 /*
  * .....
  * ....


 This patch makes this file match much of the rest of the kernel.  Why
 do you want something different?

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux