On 01.02.19 10:03, Greg Kroah-Hartman wrote:
On Fri, Feb 01, 2019 at 09:57:12AM +0100, Stefan Roese wrote:
This patch cleans up some minor issues with this driver:
- Remove unnecessary header includes
- Sort header alphabetically
- Use correct comment style
- Add return code check on device_reset()
- Remove SPI_BPW_MASK definition (already available in
include/linux/spi/spi.h)
- Use macros instead of hardcoded values for SPI_MASTER register access
as suggested by Neil Brown (in mt7621_spi_reset and mt7621_spi_prepare)
When you have to start listing the different things you do in a patch,
that's a huge sign you need to break this up into different patches :)
I personally find this over complex for these type of changes, that's
why I prefer to send such "minor" changes in a single patch. But I
can definitely split this up into multiple patches, if this is what's
preferred by you (and others).
Please do that here, it should be a series, each one doing a single type
of thing.
Sure, will do.
Thanks,
Stefan
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
