On Fri, Feb 1, 2019 at 3:07 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Thu, Jan 31, 2019 at 06:17:31PM +0800, lantianyu1986@xxxxxxxxx wrote: > > > > > > This comment needs to be indented one tab or it looks like we're outside > the funciton. > > > +/* > > + * Hyper-V doesn't provide irq remapping for IO-APIC. To enable x2apic, > > + * set x2apic destination mode to physcial mode when x2apic is available > > + * and Hyper-V IOMMU driver makes sure cpus assigned with IO-APIC irqs > > + * have 8-bit APIC id. > > + */ > > +# if IS_ENABLED(CONFIG_HYPERV_IOMMU) > > + if (x2apic_supported()) > > + x2apic_phys = 1; > > +# endif > > The IS_ENABLED() macro is really magical. You could write this like so: > > if (IS_ENABLED(CONFIG_HYPERV_IOMMU) && x2apic_supported()) > x2apic_phys = 1; > > It works the same and is slightly more pleasant to look at. Yes, that will better. Thanks for your suggestion. Dan -- Best regards Tianyu Lan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
