Re: [PATCH] drivers:staging: Fixed line more than 80 characters.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The subsystem prefix isn't right.  It should be"

[PATCH] Staging: wlan-ng: Fixed line more than 80 characters

On Wed, Jan 30, 2019 at 05:11:27PM +0100, Sandesh Kenjana Ashok wrote:
> Lines over 80 characters are adjusted according to standards
> 
> Signed-off-by: Sandesh Kenjana Ashok <kas.sandesh@xxxxxxxxx>
> ---
>  drivers/staging/wlan-ng/cfg80211.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c
> index e5d7def1f366..7687f619ee34 100644
> --- a/drivers/staging/wlan-ng/cfg80211.c
> +++ b/drivers/staging/wlan-ng/cfg80211.c
> @@ -373,7 +373,8 @@ static int prism2_scan(struct wiphy *wiphy,
>  			msg2.beaconperiod.data,
>  			ie_buf,
>  			ie_len,
> -			(msg2.signal.data - 65536) * 100, /* Conversion to signed type */
> +			/*Conversion to signed type*/

Put the spaces back:
			/* Conversion to signed type */

> +			(msg2.signal.data - 65536) * 100,
>  			GFP_KERNEL
>  		);
>  
> @@ -410,7 +411,7 @@ static int prism2_set_wiphy_params(struct wiphy *wiphy, u32 changed)
>  			data = wiphy->rts_threshold;
>  
>  		result = prism2_domibset_uint32(wlandev,
> -						DIDMIB_DOT11MAC_OPERATIONTABLE_RTSTHRESHOLD,
> +				DIDMIB_DOT11MAC_OPERATIONTABLE_RTSTHRESHOLD,
>  						data);

No.  The original code is nicer to look at.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux