On 30/01/2019 13:29, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> On Wed, Jan 30, 2019 at 02:48:27PM +0000, Carlos Henrique Lima Melara wrote:
>> This patch fix the checkpatch.p1 warning:
>>
>> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>> +/*
>
> Why did you not fix up the indentation that was already mentioned?
The Warning was about the missing SPDX License Identifier, so I added the
identifier according to the "license-rules.rst" for C source that is:
> The SPDX license identifier is added in form of a comment. The comment
> style depends on the file type::
>
> C source: // SPDX-License-Identifier: <SPDX License Expression>
> C header: /* SPDX-License-Identifier: <SPDX License Expression> */
> ASM: /* SPDX-License-Identifier: <SPDX License Expression> */
> scripts: # SPDX-License-Identifier: <SPDX License Expression>
> .rst: .. SPDX-License-Identifier: <SPDX License Expression>
> .dts{i}: // SPDX-License-Identifier: <SPDX License Expression>
I think that was the correction needed, right?
Still have a question about the license comment in the "ethtooll.c".
> /* This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> * the Free Software Foundation; version 2 of the License
> *
> * This program is distributed in the hope that it will be useful,
> * but WITHOUT ANY WARRANTY; without even the implied warranty of
> * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> * GNU General Public License for more details.
> *
> * Copyright (C) 2009-2016 John Crispin <blogic@xxxxxxxxxxx>
> * Copyright (C) 2009-2016 Felix Fietkau <nbd@xxxxxxxxxxx>
> * Copyright (C) 2013-2016 Michael Lee <igvtee@xxxxxxxxx>
> */
It puts 3 spaces between the * and the text, should it be corrected to
only one space?
thanks, Carlos Melara.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
