On 2019/1/29 16:43, Dan Carpenter wrote: > On Tue, Jan 29, 2019 at 04:35:20PM +0800, Gao Xiang wrote: >> Let's add .get_acl() to read the file's acl from its xattrs >> to make POSIX ACL usable. >> >> Here is the on-disk detail, >> fullname: system.posix_acl_access >> struct erofs_xattr_entry: >> .e_name_len = 0 >> .e_name_index = EROFS_XATTR_INDEX_POSIX_ACL_ACCESS (2) >> >> fullname: system.posix_acl_default >> struct erofs_xattr_entry: >> .e_name_len = 0 >> .e_name_index = EROFS_XATTR_INDEX_POSIX_ACL_DEFAULT (3) >> >> Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> >> Signed-off-by: Gao Xiang <gaoxiang25@xxxxxxxxxx> >> --- >> change log v4: >> - leave kmalloc and wait the conclusion of fault injection >> pointed out by Dan Carpenter; > > I do think this is the right thing, but I also wasn't going to ask you > do redo v3. Anyway, thanks! > > regards, > dan carpenter OK, let's wait the Chao's idea then... Thanks, Gao Xiang > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
