> From: Dan Williams <dan.j.williams@xxxxxxxxx> > Sent: Monday, January 28, 2019 1:55 PM > > On Mon, Jan 28, 2019 at 1:40 PM Dexuan Cui <decui@xxxxxxxxxxxxx> wrote: > > > I made the below simple change. Is this enough? Please suggest the proper > > wording/sentence, as I'm relatively new to NVDIMM, and I don't really know > the history of the standardization process. > > How about something a bit more relevant for the code in question: > > There are 4 "legacy" NVDIMM command sets > (NVDIMM_FAMILY_{INTEL,MSFT,HPE1,HPE2}) that were created before an EFI > working group was established to constrain this proliferation. The > nfit driver probes for the supported command set by GUID. Note, If > you're a platform developer looking to add a new command set to this > probe consider using an existing set, or otherwise seek approval to > publish the command set at > http://www.uefi.org/RFIC_LIST Looks perfect! Let me use this, rebase the patch to https://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm.git/tag/?h=libnvdimm-fixes-5.0-rc4 and post a v2 later today. Thanks, -- Dexuan _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel