On 1/18/19 3:59 AM, Greg Kroah-Hartman wrote: > On Fri, Jan 11, 2019 at 12:05:21PM -0600, Andrew F. Davis wrote: >> When enabled the helpers functions for creating carveout and chunk heaps >> should have declarations in the ION header. > > Why? No one calls these from what I can tell. > > Which makes me believe we should just delete the > drivers/staging/android/ion/ion_carveout_heap.c and > drivers/staging/android/ion/ion_chunk_heap.c files as there are no > in-tree users? > > Any objection to me doing that? > I use those when creating carveout heaps. My exporter is out of tree still as it uses DT and the proper bindings have not been agreed upon yet. These helpers also make good heap creation references, even if not called by anyone in-tree right now. Thanks, Andrew > thanks, > > greg k-h > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
