On Tue, Mar 15, 2011 at 04:56:38PM +0800, wwang wrote: > ä 2011å03æ15æ 16:46, Dan Carpenter åé: > > Hm... The auto detect code is never run because chip->use_hw_setting is > > always 0. Are you sure the right fix isn't to set chip->use_hw_setting > > to 1? > > > > regards, > > dan carpenter > > > Yes, setting chip->use_hw_setting is not a wise choice. > Normally, if chip->use_hw_setting is set to 1, more configurations will > be turned on, such as auto_delink_en. > auto_delink_en can only work well when pcie hotplug is configured and > pciehp.pciehp_force is set to 1. This condition can't be met in default > kernel config by now. > So, I have to choose to set lun_mode detection code in a different place. > Ok. Cool. But you're going to fix the places that use ->use_hw_setting later on yes? For example, the rts5288 chip has the same problem earlier in the file where the lun_mode doesn't get set correctly. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
