There is a lot of code related with PHY part of the mt7621 PCI driver that can be extracted to a new PHY generic driver to do the same function. This patch series add a new 'mt7621-pci-phy' driver to handle those and updates the mt7621-pci driver code to use generic kernel's PHY API. This makes the code much better and readable. Device tree has been also updated with new related bindinds for the PCI PHY part. This changes are only compile-tested. Changes in v3: - Change '#phy-cells' to be zero instead of one avoiding to implement custom 'xlate' function in phy's driver. All of phy types for the phy driver are 'PHY_TYPE_PCIE' which is for that the '#phy-cells' was using for. There is no sense to check the type in a custom 'xlate' function. Phy's driver 'mt7621_pci_phy_xlate' has been deleted and now the generic 'of_phy_simple_xlate' is being used. - Update MODULE_LICENSE to use 'GPL v2' instead of 'GPL'. - Add kernel doc for phy's driver data structures. - Add a PATCH with DT bindings documentation. Changes in v2: - PATCH 1: remap registers first and assign virtual address after for each port because they share the same address space. Hope this helps. Thanks in advance. Best regards, Sergio Paracuellos Sergio Paracuellos (4): staging: mt7621-pci-phy: add new driver for phy part of mt7621-pci staging: mt7621-pci: handle phy using new generic phy 'pci-mt7621-phy' driver staging: mt7621-dts: add pci-phy related bindings to board's device tree staging: mt7621-pci-phy: dt-bindings: add bindings for Mediatek MT7621 Pcie PHY drivers/staging/Kconfig | 2 + drivers/staging/Makefile | 1 + drivers/staging/mt7621-dts/mt7621.dtsi | 31 ++ drivers/staging/mt7621-pci-phy/Kconfig | 7 + drivers/staging/mt7621-pci-phy/Makefile | 1 + drivers/staging/mt7621-pci-phy/TODO | 4 + .../mediatek,mt7621-pci-phy.txt | 54 +++ .../staging/mt7621-pci-phy/pci-mt7621-phy.c | 387 ++++++++++++++++++ drivers/staging/mt7621-pci/pci-mt7621.c | 250 ++--------- 9 files changed, 519 insertions(+), 218 deletions(-) create mode 100644 drivers/staging/mt7621-pci-phy/Kconfig create mode 100644 drivers/staging/mt7621-pci-phy/Makefile create mode 100644 drivers/staging/mt7621-pci-phy/TODO create mode 100644 drivers/staging/mt7621-pci-phy/mediatek,mt7621-pci-phy.txt create mode 100644 drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c -- 2.19.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel