[driver-core:debugfs_cleanup 51/61] drivers/opp/debugfs.c:66:9: warning: 'return' with a value, in function returning void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git debugfs_cleanup
head:   d8de692bccca02a757f4d4c2de9805b561497014
commit: 19410727eb72c71fd3c6c0398e3e8e8ac236f696 [51/61] opp: no need to check return value of debugfs_create functions
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 19410727eb72c71fd3c6c0398e3e8e8ac236f696
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sh 

All warnings (new ones prefixed by >>):

   drivers/opp/debugfs.c: In function 'opp_debug_create_supplies':
>> drivers/opp/debugfs.c:66:9: warning: 'return' with a value, in function returning void
     return true;
            ^~~~
   drivers/opp/debugfs.c:38:13: note: declared here
    static void opp_debug_create_supplies(struct dev_pm_opp *opp,
                ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/opp/debugfs.c: In function 'opp_list_debug_create_link':
   drivers/opp/debugfs.c:123:23: warning: unused variable 'dev' [-Wunused-variable]
     const struct device *dev = opp_dev->dev;
                          ^~~

vim +/return +66 drivers/opp/debugfs.c

deaa5146 drivers/base/power/opp/debugfs.c Viresh Kumar       2015-11-11  37  
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  38  static void opp_debug_create_supplies(struct dev_pm_opp *opp,
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  39  				      struct opp_table *opp_table,
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  40  				      struct dentry *pdentry)
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  41  {
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  42  	struct dentry *d;
1fae788e drivers/base/power/opp/debugfs.c Viresh Kumar       2017-05-23  43  	int i;
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  44  
1fae788e drivers/base/power/opp/debugfs.c Viresh Kumar       2017-05-23  45  	for (i = 0; i < opp_table->regulator_count; i++) {
d741029a drivers/opp/debugfs.c            Arvind Yadav       2017-09-21  46  		char name[15];
d741029a drivers/opp/debugfs.c            Arvind Yadav       2017-09-21  47  
d741029a drivers/opp/debugfs.c            Arvind Yadav       2017-09-21  48  		snprintf(name, sizeof(name), "supply-%d", i);
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  49  
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  50  		/* Create per-opp directory */
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  51  		d = debugfs_create_dir(name, pdentry);
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  52  
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  53  		debugfs_create_ulong("u_volt_target", S_IRUGO, d,
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  54  				     &opp->supplies[i].u_volt);
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  55  
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  56  		debugfs_create_ulong("u_volt_min", S_IRUGO, d,
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  57  				     &opp->supplies[i].u_volt_min);
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  58  
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  59  		debugfs_create_ulong("u_volt_max", S_IRUGO, d,
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  60  				     &opp->supplies[i].u_volt_max);
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  61  
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  62  		debugfs_create_ulong("u_amp", S_IRUGO, d,
19410727 drivers/opp/debugfs.c            Greg Kroah-Hartman 2019-01-03  63  				     &opp->supplies[i].u_amp);
1fae788e drivers/base/power/opp/debugfs.c Viresh Kumar       2017-05-23  64  	}
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  65  
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01 @66  	return true;
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  67  }
dfbe4678 drivers/base/power/opp/debugfs.c Viresh Kumar       2016-12-01  68  

:::::: The code at line 66 was first introduced by commit
:::::: dfbe4678d709e25e0f36e6b6333e2a7a67aefb7e PM / OPP: Add infrastructure to manage multiple regulators

:::::: TO: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
:::::: CC: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux