On Thu, Jan 3, 2019 at 3:02 AM NeilBrown <neil@xxxxxxxxxx> wrote: > > On Mon, Dec 31 2018, Sergio Paracuellos wrote: > > > dt_node_to_map and dt_free_map operations can use pinconf-generic API's > > instead of redefine operations in the driver. Make use of them cleaning > > a bit driver's code. > > > > Update DT accordly to make sure used bindings property in code match > > with the board's DT bindings. > > > > Changes are only compile-tested. > > Thanks. This appears to work for me. > It is awkward to test pinctrl changes because the firmware preconfigures > all the pins, so the hardware will work correctly if pinctrl does > nothing. > So I change the dts file to mis-configure some pins for driving LEDs, > and checked that the LEDs broken. The fixed the dts, and the LEDs > started working again. > I think that will have to do. > > Tested-by: NeilBrown <neil@xxxxxxxxxx> > > Thanks, > NeilBrown Cool! Thanks for testing and let me know. So, I sent this patch which solves a problem: http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-December/130260.html And this new patch is generated with that applied. Also this patch solves the original problem also and seems the way to go... Should be better to re-do this one with all the fixed and reported by tags added as a solution? What do you prefer, Greg? Thanks in advance. Best regards, Sergio Paracuellos > > > > > > Hope this helps. > > > > Best regards, > > Sergio Paracuellos > > > > Sergio Paracuellos (2): > > staging: mt7621-pinctrl: use pinconf-generic for 'dt_node_to_map' and > > 'dt_free_map' > > staging: mt7621-dts: use standard 'groups' instead of 'group' for > > pinctrl bindings > > > > drivers/staging/mt7621-dts/gbpc1.dts | 4 +- > > drivers/staging/mt7621-dts/mt7621.dtsi | 24 +++++------ > > drivers/staging/mt7621-pinctrl/Kconfig | 1 + > > .../staging/mt7621-pinctrl/pinctrl-rt2880.c | 42 ++----------------- > > 4 files changed, 18 insertions(+), 53 deletions(-) > > > > -- > > 2.19.1 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
