Re: [PATCH] rts5208: fix a missing check of ms read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 20, 2018 at 02:00:01PM -0600, Kangjie Lu wrote:
> When ms_read_extra_data fails, the data read in "extra" buffer is
> just incorrect and thus should be used. However, "extra" is used
> in multiple places no matter ms_read_extra_data() fails or not.
> The fix checks the status of ms_read_extra_data() and returns with
> an error code upon its failure.
> 
> Signed-off-by: Kangjie Lu <kjlu@xxxxxxx>

Looks good.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux