Re: [PATCH 15/18] staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 30 2018, Sergio Paracuellos wrote:

> Hi again and sorry for the noise.

A bit of noise is no problem, especially when it leads to the right
answer.

>
> +       *num_maps = 0;

Yes, this works.
I had tried other numbers like ngroups, and got strange errors.
With this, it all works.

>
> Looking other drivers and 'pinctrl_utils_reserve_map' code it seems
> this should be first set to zero.

Yes, I can see that now in pinconf_generic_dt_node_to_map() which is a
lot of driver use ... I wonder if we can use the 'generic' one too.

Anyway,
  Reported-and-tested-by: NeilBrown <neil@xxxxxxxxxx>

for the addition of
  *num_maps = 0;

Thanks!
NeilBrown

Attachment: signature.asc
Description: PGP signature

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux