Hi Yangtao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.20-rc7 next-20181221] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Yangtao-Li/staging-rtlwifi-convert-to-DEFINE_SHOW_ATTRIBUTE/20181222-085444 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 All warnings (new ones prefixed by >>): drivers/staging/rtlwifi/debug.c: In function 'rtl_debug_add_one': drivers/staging/rtlwifi/debug.c:515:10: error: 'fopname_fops' undeclared (first use in this function); did you mean 'replace_fops'? &fopname_ ##fops); \ ^ >> drivers/staging/rtlwifi/debug.c:519:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~~~~~~~~~~~~~~~~~ drivers/staging/rtlwifi/debug.c:545:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~~~~~~~~~~~~~ drivers/staging/rtlwifi/debug.c:515:10: note: each undeclared identifier is reported only once for each function it appears in &fopname_ ##fops); \ ^ >> drivers/staging/rtlwifi/debug.c:519:3: note: in expansion of macro 'RTL_DEBUGFS_ADD_CORE' RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) ^~~~~~~~~~~~~~~~~~~~ drivers/staging/rtlwifi/debug.c:545:2: note: in expansion of macro 'RTL_DEBUGFS_ADD' RTL_DEBUGFS_ADD(mac_0); ^~~~~~~~~~~~~~~ vim +/RTL_DEBUGFS_ADD_CORE +519 drivers/staging/rtlwifi/debug.c 56bde846 Ping-Ke Shih 2017-08-17 509 56bde846 Ping-Ke Shih 2017-08-17 510 #define RTL_DEBUGFS_ADD_CORE(name, mode, fopname) \ 56bde846 Ping-Ke Shih 2017-08-17 511 do { \ 56bde846 Ping-Ke Shih 2017-08-17 512 rtl_debug_priv_ ##name.rtlpriv = rtlpriv; \ e206a0d4 Greg Kroah-Hartman 2018-05-29 513 debugfs_create_file(#name, mode, parent, \ e206a0d4 Greg Kroah-Hartman 2018-05-29 514 &rtl_debug_priv_ ##name, \ e8b4e2be Yangtao Li 2018-12-21 @515 &fopname_ ##fops); \ 56bde846 Ping-Ke Shih 2017-08-17 516 } while (0) 56bde846 Ping-Ke Shih 2017-08-17 517 56bde846 Ping-Ke Shih 2017-08-17 518 #define RTL_DEBUGFS_ADD(name) \ 56bde846 Ping-Ke Shih 2017-08-17 @519 RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0444, common) 56bde846 Ping-Ke Shih 2017-08-17 520 #define RTL_DEBUGFS_ADD_W(name) \ b55ade19 Larry Finger 2017-08-24 521 RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0222, common_write) 56bde846 Ping-Ke Shih 2017-08-17 522 #define RTL_DEBUGFS_ADD_RW(name) \ b55ade19 Larry Finger 2017-08-24 523 RTL_DEBUGFS_ADD_CORE(name, S_IFREG | 0666, common_rw) 56bde846 Ping-Ke Shih 2017-08-17 524 :::::: The code at line 519 was first introduced by commit :::::: 56bde846304ea05d5f8c8de0e3a42627a7a92be6 staging: r8822be: Add existing rtlwifi and rtl_pci parts for new driver :::::: TO: Ping-Ke Shih <pkshih@xxxxxxxxxxx> :::::: CC: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
