I think maybe this is the first kernel patch I have recieved from you. When you're adding error handling there are a couple ways to go wrong and this is what I look at when I review error handling patches: 1) The error handling is not required. 2) The error handling is not complete. I have messed up on both of these in my own patches because sometimes the code is complicated to understand. Sometimes there isn't any way to recover from errors. For example, we sometimes deliberately assume that the PCI bus is working because if it's not the real fix is to buy new hardware. Another thing that helps is to try write about the real world impact about the patch in the changelog. Try ask, why has that bug not been found before? Always take a look at how the function is called and the wider context. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
