Re: [PATCH] staging: rtlwifi: Fix one line with over 80 chars.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 18, 2018 at 10:30:05AM -0500, Lei Zhou wrote:
> Add local temporary variable used as buffer to pass caller pointer into
> function ieee80211_connection_loss() to avoid over 80 characters on one
> line.
> 
> Signed-off-by: Lei Zhou <zlhk2018@xxxxxxxxx>
> ---
>  drivers/staging/rtlwifi/base.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c
> index 35df2cf..8bd1a78 100644
> --- a/drivers/staging/rtlwifi/base.c
> +++ b/drivers/staging/rtlwifi/base.c
> @@ -1979,6 +1979,7 @@ void rtl_watchdog_wq_callback(void *data)
>  	struct rtl_priv *rtlpriv = rtl_priv(hw);
>  	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
>  	struct rtl_mac *mac = rtl_mac(rtl_priv(hw));
> +	struct ieee80211_vif *vif = NULL;
>  	bool busytraffic = false;
>  	bool tx_busy_traffic = false;
>  	bool rx_busy_traffic = false;
> @@ -2130,7 +2131,8 @@ void rtl_watchdog_wq_callback(void *data)
>  			if (rtlpriv->link_info.roam_times >= 5) {
>  				pr_err("AP off, try to reconnect now\n");
>  				rtlpriv->link_info.roam_times = 0;
> -				ieee80211_connection_loss(rtlpriv->mac80211.vif);
> +				vif = rtlpriv->mac80211.vif;
> +				ieee80211_connection_loss(vif);

That really is not worth the effort to fix a line that is one character
"too big".  It's fine as-is.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux