Hi Christian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v4.20-rc6 next-20181212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Christian-Brauner/binder-implement-binderfs/20181210-003538 config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 All warnings (new ones prefixed by >>): include/linux/slab.h:332:43: warning: dubious: x & !y include/linux/slab.h:332:43: warning: dubious: x & !y >> drivers/android/binderfs.c:232:43: warning: incorrect type in initializer (different address spaces) drivers/android/binderfs.c:232:43: expected struct binderfs_device *device drivers/android/binderfs.c:232:43: got struct binderfs_device [noderef] <asn:1>*<noident> >> drivers/android/binderfs.c:238:51: warning: incorrect type in argument 2 (different address spaces) drivers/android/binderfs.c:238:51: expected void const [noderef] <asn:1>*from drivers/android/binderfs.c:238:51: got struct binderfs_device *device drivers/android/binderfs.c:242:60: warning: incorrect type in argument 2 (different address spaces) drivers/android/binderfs.c:242:60: expected struct binderfs_device [noderef] <asn:1>*userp drivers/android/binderfs.c:242:60: got struct binderfs_device *device include/linux/slab.h:332:43: warning: dubious: x & !y include/linux/slab.h:332:43: warning: dubious: x & !y vim +232 drivers/android/binderfs.c 215 216 /** 217 * binderfs_ctl_ioctl - handle binder device node allocation requests 218 * 219 * The request handler for the binder-control device. All requests operate on 220 * the binderfs mount the binder-control device resides in: 221 * - BINDER_CTL_ADD 222 * Allocate a new binder device. 223 * 224 * Return: 0 on success, negative errno on failure 225 */ 226 static long binder_ctl_ioctl(struct file *file, unsigned int cmd, 227 unsigned long arg) 228 { 229 struct binderfs_info *info; 230 int ret = -EINVAL; 231 struct inode *inode = file_inode(file); > 232 struct binderfs_device *device = (struct binderfs_device __user *)arg; 233 struct binderfs_device device_req; 234 235 info = BINDERFS_I(inode); 236 switch (cmd) { 237 case BINDER_CTL_ADD: > 238 ret = copy_from_user(&device_req, device, sizeof(device_req)); 239 if (ret) 240 break; 241 242 ret = binderfs_binder_device_create(inode, device, &device_req); 243 break; 244 default: 245 break; 246 } 247 248 return ret; 249 } 250 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
