On Tue, Dec 11, 2018 at 07:30:58PM +0100, Dominic Braun wrote:
> Typedefing structs is not encouraged in the kernel.
>
> The removal of typedefs was requested in interface/vchi/TODO in commit
> 7626e002225a4c1b9455689b1f22909dfeff43ca.
>
> Signed-off-by: Dominic Braun <inf.braun@xxxxxx>
> Signed-off-by: Tobias Büttner <tobias.buettner@xxxxxx>
> ---
> .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index f28f681192dd..7f670852102d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -153,12 +153,12 @@ struct vchiq_instance_struct {
> VCHIQ_DEBUGFS_NODE_T debugfs_node;
> };
>
> -typedef struct dump_context_struct {
> +struct dump_context_struct {
Like Dan pointed out, don't name your structs "struct foo_struct" that's
just wasted text. It should just be "struct foo".
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
