On Tue, Dec 04, 2018 at 02:19:38AM +0000, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux > > This staging driver is modified from this upstream driver at https://github.com/KastnerRG/riffa/tree/master/driver/linux Please properly wrap your changelog text at 72 columns > For further details, please refer to https://github.com/KastnerRG/riffa/pull/31 That is not permanent, please provide the details here. > Signed-off-by: Cheng Fei Phung <feiphung@xxxxxxxxxxx> > > --- > Changes in v1: > - added full-duplex capability And ignored everything else I asked about? That's not nice to reviewers at all. Please at least comment on things that have been asked about, otherwise why would anyone want to review this? Also, is this "v2"? You didn't say so in your subject line. Please fix this all up and submit a v3, after at least commenting on the things asked previously. Also, you still have this line which prevents me from being able to accept this patch, as I talked about previously: > + {PCI_DEVICE(VENDOR_ID1, PCI_ANY_ID)}, Do NOT just bind to all PCI devices from a vendor, that will break other drivers in the system. Also, do not use a random MAJOR number that you just picked out of no where, that too will break working systems and needs to be fixed. Use the dynamic allocation method, or better yet, just use a misc device. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
