Re: [PATCH 21/22] staging: xgifb: rename XGINew_SetRegANDOR() to xgifb_reg_and_or()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sat, 12 Mar 2011, Dan Carpenter wrote:
On Thu, Mar 10, 2011 at 11:02:46PM +0200, Aaro Koskinen wrote:
Rename XGINew_SetRegANDOR() to xgifb_reg_and_or().

Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxx>
---

-void XGINew_SetRegANDOR(unsigned long Port, unsigned short Index,
-		unsigned short DataAND, unsigned short DataOR)
+void xgifb_reg_and_or(unsigned long port, u8 index, unsigned data_and,
                                            ^^^^^^^^  ^^^^^^^^^^^^^^^^^
+		      unsigned data_or)
                     ^^^^^^^^^^^^^^^^
I wish the change log had mentioned some of these data type changes.  It
doesn't cause a bug, but it still should have been mentioned.

Yes, you are right. Those cleanups were actually ment to be in a separate
patch. I will redo the patches.

Thanks,

A.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel


[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux