Re: [PATCH v2 5/7] staging: mt7621-pci: avoid using clk_* operations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Nov 24, 2018 at 06:54:55PM +0100, Sergio Paracuellos wrote:
> There is no clock driver for ralink mips and clk_enable
> are no-ops for this architecture. This has been also tested
> without using clocks and seems to work so avoid to use them
> in this driver.
> 
> Fixes: ad9c87e129d1: "staging: mt7621-pci: parse and init
> port data from device tree"
> Reported-by: NeilBrown <neil@xxxxxxxxxx>
> 
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>

This is fine, but in the future just let the Fixes tag go over the 75
character limit without wrapping it.  checkpatch.pl shouldn't complain.

Also you don't need to put a blank line between the Reported-by and the
S-o-b.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel



[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux