> -----Original Message----- > From: Hank Janssen > Sent: Thursday, March 10, 2011 5:54 PM > To: Thomas Gleixner > Cc: KY Srinivasan; gregkh@xxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > devel@xxxxxxxxxxxxxxxxxxxxxx; virtualization@xxxxxxxxxxxxxx; Haiyang Zhang; Mike > Sterling; Abhishek Kane (Mindtree Consulting PVT LTD) > Subject: Re: [PATCH 12/21] Staging: hv: Cleanup irq management > > > > > > > On Mar 10, 2011, at 14:46, "Thomas Gleixner" <tglx@xxxxxxxxxxxxx> wrote: > >> > > > >> } > >> - vector = VMBUS_IRQ_VECTOR; > >> > >> - DPRINT_INFO(VMBUS_DRV, "irq 0x%x vector 0x%x", vmbus_irq, vector); > >> + vector = IRQ0_VECTOR + pdev->irq; > >> + DPRINT_INFO(VMBUS_DRV, "irq 0x%x vector 0x%x", pdev->irq, > >> + IRQ0_VECTOR + pdev->irq); > > > > Why evaluating vector first and then not using it for that debug print > > thingy? Good point; I will fix this before Hank gets rid of the DPRINT_INFO altogether. Regards, K. Y _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
