Hi Greg, On 2018/11/22 18:17, Greg Kroah-Hartman wrote: > Any specific reason why you are not using the refcount.h api instead of > "doing it yourself" with atomic_inc/dec()? > > I'm not rejecting this, just curious. As I explained in the previous email, Re: [PATCH 04/10] staging: erofs: fix `erofs_workgroup_{try_to_freeze, unfreeze}' we need such a function when the value is >= 0, it plays as a refcount, but when the refcount == EROFS_LOCKED_MAGIC (<0, but not 0 as refcount.h), and actually there is no need to introduce a seperate spinlock_t because we don't actually care about its performance (rarely locked). and the corresponding struct is too large for now, we need to decrease its size. Thanks, Gao Xiang > > thanks, > > greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel