On 21.11.18 04:22, Nadav Amit wrote: > Thanks for this patch! > >> On Nov 19, 2018, at 2:16 AM, David Hildenbrand <david@xxxxxxxxxx> wrote: >> >> Mark inflated and never onlined pages PG_offline, to tell the world that >> the content is stale and should not be dumped. >> >> Cc: Xavier Deguillard <xdeguillard@xxxxxxxxxx> >> Cc: Nadav Amit <namit@xxxxxxxxxx> >> Cc: Arnd Bergmann <arnd@xxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: Julien Freche <jfreche@xxxxxxxxxx> >> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> >> Cc: Matthew Wilcox <willy@xxxxxxxxxxxxx> >> Cc: Michal Hocko <mhocko@xxxxxxxx> >> Cc: "Michael S. Tsirkin" <mst@xxxxxxxxxx> >> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx> >> --- >> drivers/misc/vmw_balloon.c | 32 ++++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> >> diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c >> index e6126a4b95d3..8cc8bd9a4e32 100644 >> --- a/drivers/misc/vmw_balloon.c >> +++ b/drivers/misc/vmw_balloon.c >> @@ -544,6 +544,36 @@ unsigned int vmballoon_page_order(enum vmballoon_page_size_type page_size) >> return page_size == VMW_BALLOON_2M_PAGE ? VMW_BALLOON_2M_ORDER : 0; >> } >> >> +/** >> + * vmballoon_mark_page_offline() - mark a page as offline >> + * @page: pointer for the page > > If possible, please add a period at the end of the sentence (yes, I know I > got it wrong in some places too). Sure :) > >> + * @page_size: the size of the page. >> + */ >> +static void >> +vmballoon_mark_page_offline(struct page *page, >> + enum vmballoon_page_size_type page_size) >> +{ >> + int i; >> + >> + for (i = 0; i < 1ULL << vmballoon_page_order(page_size); i++) > > Can you please do instead: > > unsigned int; > > for (i = 0; i < vmballoon_page_in_frames(page_size); i++) > Will do, will have to move both functions a little bit down in the file (exactly one function). > We would like to test it in the next few days, but in the meanwhile, after > you address these minor issues: > > Acked-by: Nadav Amit <namit@xxxxxxxxxx> Thanks! > > Thanks again, > Nadav > -- Thanks, David / dhildenb _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel