On 11/8/18 11:34 AM, Alexey Skidanov wrote:
On 11/8/18 9:15 PM, Laura Abbott wrote:
On 10/22/18 2:15 PM, Alexey Skidanov wrote:
Heap name is mundatory.
I'm wary of this and the other change because it misses the
broader problem of dealing with the carveout heaps.
I still want to remove the carveout and chunk heap. I get
that it's being used for out of tree work but at this point
the focus needs to be on moving Ion out of staging and
if we can't get an end-to-end solution for carveout/chunk
heaps to be allocated in tree this needs to be removed.
Thanks,
Laura
There are several options I would suggest:
1. The heaps may be initialized by parsing some kernel parameter,
defining the contiguous chunks
2. Some functions may be exported by ION to initialize the heaps
3. CONFIG_XXX options (just like it's in CMA)
We've had lots of suggestions but nobody has actually stepped
up to submit patches to make this work. If you'd like to submit
patches that would be great.
Thanks,
Laura
Thanks,
Alexey
Signed-off-by: Alexey Skidanov <alexey.skidanov@xxxxxxxxx>
---
drivers/staging/android/ion/ion_carveout_heap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion_carveout_heap.c
b/drivers/staging/android/ion/ion_carveout_heap.c
index e129237..e89b464 100644
--- a/drivers/staging/android/ion/ion_carveout_heap.c
+++ b/drivers/staging/android/ion/ion_carveout_heap.c
@@ -131,6 +131,7 @@ struct ion_heap *ion_carveout_heap_create(struct
ion_platform_heap *heap_data)
gen_pool_add(carveout_heap->pool, carveout_heap->base,
heap_data->size,
-1);
carveout_heap->heap.ops = &carveout_heap_ops;
+ carveout_heap->heap.name = heap_data->name;
carveout_heap->heap.type = ION_HEAP_TYPE_CARVEOUT;
carveout_heap->heap.flags = ION_HEAP_FLAG_DEFER_FREE;
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
