On Mon, Oct 22, 2018 at 03:41:05AM +0000, Cheng Fei Phung wrote: > This patch adds RIFFA PCIe linux driver for https://github.com/promach/riffa/tree/full_duplex/driver/linux > This staging driver is modified from this upstream driver at https://github.com/KastnerRG/riffa/tree/master/driver/linux Please properly line-wrap your changelog text at 72 columns when you can. > > Signed-off-by: PHUNG CHENG FEI <feiphung@xxxxxxxxxxx> No need to put your name in ALL CAPS. It should also match your from: line in the email header, which it does not here. There's lots to fix up in this code, and normally that is fine, but I can't take the driver right now because of these lines: > +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 8, 0) > +static DEFINE_PCI_DEVICE_TABLE(fpga_ids) = > +#else > +static const struct pci_device_id fpga_ids[] = > +#endif > + { > + { PCI_DEVICE(VENDOR_ID0, PCI_ANY_ID) }, > + { PCI_DEVICE(VENDOR_ID1, PCI_ANY_ID) }, > + { 0 }, > + }; > + > +MODULE_DEVICE_TABLE(pci, fpga_ids); You are grabbing ALL pci devices from these two vendors (Xilinx and Altera). That will instantly break any of the existing kernel drivers for any random device from those vendors by having this driver bind to the device instead. And that's not ok, you can not break working systems, sorry. Please be very specific and only have the driver bind to the correct hardware devices. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
