On Mon, 2018-11-05 at 17:16 -0200, Renato Lui Geh wrote: > This patch removes the unnecessary field int_vref_mv in ad7780_state > referring to the device's voltage. > Looks good from my side. Alex > Signed-off-by: Renato Lui Geh <renatogeh@xxxxxxxxx> > --- > Changes in v3: > - removed unnecessary int_vref_mv from ad7780_state > Changes in v4: > - removed voltage reading on probe > > drivers/staging/iio/adc/ad7780.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/staging/iio/adc/ad7780.c > b/drivers/staging/iio/adc/ad7780.c > index c7cb05cedbbc..52a914360574 100644 > --- a/drivers/staging/iio/adc/ad7780.c > +++ b/drivers/staging/iio/adc/ad7780.c > @@ -42,7 +42,6 @@ struct ad7780_state { > struct regulator *reg; > struct gpio_desc *powerdown_gpio; > unsigned int gain; > - u16 int_vref_mv; > > struct ad_sigma_delta sd; > }; > @@ -165,7 +164,7 @@ static int ad7780_probe(struct spi_device *spi) > { > struct ad7780_state *st; > struct iio_dev *indio_dev; > - int ret, voltage_uv = 0; > + int ret; > > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); > if (!indio_dev) > @@ -185,16 +184,10 @@ static int ad7780_probe(struct spi_device *spi) > dev_err(&spi->dev, "Failed to enable specified AVdd > supply\n"); > return ret; > } > - voltage_uv = regulator_get_voltage(st->reg); > > st->chip_info = > &ad7780_chip_info_tbl[spi_get_device_id(spi)->driver_data]; > > - if (voltage_uv) > - st->int_vref_mv = voltage_uv / 1000; > - else > - dev_warn(&spi->dev, "Reference voltage unspecified\n"); > - > spi_set_drvdata(spi, indio_dev); > > indio_dev->dev.parent = &spi->dev; _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel