Re: [PATCH] staging: Remove the mt29f_spinand driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

Boris Brezillon <boris.brezillon@xxxxxxxxxxx> wrote on Mon, 22 Oct 2018
22:10:59 +0200:

> A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and
> Micron's MT29F devices are now supported in
> drivers/mtd/nand/spi/micron.c.
> 
> Remove the old driver.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>
> ---
> Hello,
> 
> If anything is missing in drivers/mtd/nand/spi/micron.c to properly
> support the devices supported by the mt29f_spinand driver, please let
> me know.
> I might accept to delay removal of this driver if I have some guarantees
> that existing users will actually switch to the new driver at some
> point.
> 
> Regards,
> 
> Boris
> ---

I plan to apply this patch but I would like your approval first.

As a summary, the mt29f_spinand driver is a Micron SPI NAND chip
driver interfacing with the raw NAND API (which is 'wrong').

Boris has recently contributed a SPI NAND framework supporting SPI
NAND chips from several vendors, including Micron, that is supposed to
take over this driver.

Do you see anything that should prevent us to remove it now?

>  drivers/staging/Kconfig                       |   2 -
>  drivers/staging/Makefile                      |   1 -
>  drivers/staging/mt29f_spinand/Kconfig         |  16 -
>  drivers/staging/mt29f_spinand/Makefile        |   1 -
>  drivers/staging/mt29f_spinand/TODO            |  13 -
>  drivers/staging/mt29f_spinand/mt29f_spinand.c | 980 ------------------
>  drivers/staging/mt29f_spinand/mt29f_spinand.h | 106 --
>  7 files changed, 1119 deletions(-)
>  delete mode 100644 drivers/staging/mt29f_spinand/Kconfig
>  delete mode 100644 drivers/staging/mt29f_spinand/Makefile
>  delete mode 100644 drivers/staging/mt29f_spinand/TODO
>  delete mode 100644 drivers/staging/mt29f_spinand/mt29f_spinand.c
>  delete mode 100644 drivers/staging/mt29f_spinand/mt29f_spinand.h
> 

Thanks,
Miquèl
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux